🦊 Update dependencies #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the failing test case it's not immediately obvious to me what is supposed to fail and why. |
|
Hi @huacnlee, any chance to get this PR merged soon? From what I can see, there are lots of old deps when installing |
|
I have open a new PR, and keep @Jasper-Bekkers you commit sign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a pretty strict CI for duplicate dependencies in our project, and it cought some out-dated dependencies when integrating
rust-i18ninto our project.This PR switches this project over to use workspace dependencies for ease of use (now there's only one place where all the versions are defined, so only one place to update!)
I've also taken the liberty in this PR to update some of the dependencies to at least be on the same level as our project (for example: serde_yaml 0.8 had a security warning issues against it because it depended on
yaml-rustwhich was left unmaintained).